Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inter: 3.5 -> 3.7 #62352

Merged
merged 2 commits into from Jun 4, 2019
Merged

inter: 3.5 -> 3.7 #62352

merged 2 commits into from Jun 4, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jun 1, 2019

Motivation for this change

Hot on the tail of 3.6, 3.7 is available!
Get yours now before supplies run out! :P

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz fpletz mentioned this pull request Jun 1, 2019
Closed
10 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Jun 4, 2019

(merging, but concerns and such still encouraged -- especially if there's a disagreement re:resolution of comments above!)

❤️

@dtzWill dtzWill merged commit 95fbb12 into NixOS:master Jun 4, 2019
@dtzWill dtzWill deleted the update/inter-3.7 branch June 4, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @mmahut