Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teeworlds: fetchSubmodules #62532

Merged
merged 1 commit into from
Jun 9, 2019
Merged

teeworlds: fetchSubmodules #62532

merged 1 commit into from
Jun 9, 2019
+2 −1

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jun 2, 2019

Motivation for this change

The languages and maps directories are submodules, and are not included in tarballs downloaded from GitHub. This results in an English-only game that can't run a server.

An alternative approach would have been to use an official release tarball, which is hosted on GitHub as a release artifact.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@alyssais
teeworlds: fetchSubmodules
356938c 
The languages and maps directories are submodules, and are not included
in tarballs downloaded from GitHub. This results in an English-only game
that can't run a server.
@alyssais alyssais added the 9.needs: port to stable A PR needs a backport to the stable release. label Jun 2, 2019
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 2, 2019
vcunat
vcunat approved these changes Jun 9, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC fetchSubmodules had some issues around stability of the hash, but hopefully it won't be too bad (maybe it has got fixed).

@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

/cc maintainer @astsmtl.

@vcunat vcunat merged commit 356938c into NixOS:master Jun 9, 2019
vcunat added a commit that referenced this pull request Jun 9, 2019
@vcunat
Merge #62532: teeworlds: fetchSubmodules
dd589ad
@alyssais alyssais deleted the teeworlds branch June 9, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @vcunat