Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haskell override clean up #62407

Closed
wants to merge 86 commits into from

Conversation

infinisil
Copy link
Member

Ping @peti, specifically for the first point on jailbreak-cabal:

  • jailbreak-cabal override isn't needed, shared executables are disabled
    by default (or is this precautionary?)
  • Removed and added some infinite recursion overrides, moved them to
    configuration-nix.nix
  • Unbreak zstd and attparsec-varword
  • mysql override is already in configuration-nix.nix
  • Move some overrides for disabling tests due to internet connectivity
    to configuration-nix.nix
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti and others added 30 commits May 26, 2019 02:30
This update was generated by hackage2nix v2.14.3-4-g5a23331 from Hackage revision
commercialhaskell/all-cabal-hashes@aa073d9.
This update was generated by hackage2nix v2.14.3-4-g5a23331 from Hackage revision
commercialhaskell/all-cabal-hashes@13027e9.
alioth.debian.org is gone
Fixes corrupted OMEMO messages from Gajim.
Previously we used nothing, leading to NixOS#25273.

Big thanks to @t184256 for developing and testing this fix.

Fixes NixOS#25273.
The URL was mistakenly truncated in the following commit:
    57bccb3 treewide: http -> https sources (NixOS#42676)
In the latest version (0.5.3+git20190105), `<X11/xlib.h>` isn't directly
included in `fb_imlib2.c` anymore, however it's used by `<Imlib.h>`
which broke our patch which disables X11 here.

Hydra build failure: https://hydra.nixos.org/build/93730733
See also tats/w3m@2266d1b
Use the description from the manpage / upstream repository.
rvolosatovs and others added 14 commits May 27, 2019 12:38
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This update was generated by hackage2nix v2.14.3-4-g5a23331 from Hackage revision
commercialhaskell/all-cabal-hashes@18a6236.
This update was generated by hackage2nix v2.14.3-4-g5a23331 from Hackage revision
commercialhaskell/all-cabal-hashes@5cb0245.
This update was generated by hackage2nix v2.14.3-4-g5a23331 from Hackage revision
commercialhaskell/all-cabal-hashes@3ef6ab6.
This update was generated by hackage2nix v2.14.3-4-g5a23331 from Hackage revision
commercialhaskell/all-cabal-hashes@ee223e1.
This update was generated by hackage2nix v2.14.3-6-g315012a from Hackage revision
commercialhaskell/all-cabal-hashes@5a3c3ef.
This update was generated by hackage2nix v2.14.3-6-g315012a from Hackage revision
commercialhaskell/all-cabal-hashes@f488db6.
- jailbreak-cabal override isn't needed, shared executables are disabled
by default (or is this precautionary?)
- Removed and added some infinite recursion overrides, moved them to
configuration-nix.nix
- Unbreak zstd and attparsec-varword
- mysql override is already in configuration-nix.nix
- Move some overrides for disabling tests due to internet connectivity
to configuration-nix.nix
@peti
Copy link
Member

peti commented Jun 4, 2019

I merged the heap fix directly into master as 45d7270.

@peti peti force-pushed the haskell-updates branch 2 times, most recently from 2250de3 to 6f19c99 Compare June 4, 2019 08:33
peti pushed a commit that referenced this pull request Jun 4, 2019
- jailbreak-cabal override isn't needed, shared executables are disabled
  by default (or is this precautionary?)

- Removed and added some infinite recursion overrides, moved them to
  configuration-nix.nix

- Unbreak zstd and attparsec-varword

- mysql override is already in configuration-nix.nix

- Move some overrides for disabling tests due to internet connectivity
  to configuration-nix.nix

Closes #62407.
@peti
Copy link
Member

peti commented Jun 4, 2019

6f19c99 merged to haskell-updates.

@peti peti closed this Jun 4, 2019
peti pushed a commit that referenced this pull request Jun 7, 2019
- jailbreak-cabal override isn't needed, shared executables are disabled
  by default (or is this precautionary?)

- Removed and added some infinite recursion overrides, moved them to
  configuration-nix.nix

- Unbreak zstd and attparsec-varword

- mysql override is already in configuration-nix.nix

- Move some overrides for disabling tests due to internet connectivity
  to configuration-nix.nix

Closes #62407.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet