Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ejabberd: 19.02 -> 19.05 #62408

Merged
merged 1 commit into from Jun 1, 2019
Merged

ejabberd: 19.02 -> 19.05 #62408

merged 1 commit into from Jun 1, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Jun 1, 2019 •
edited

Motivation for this change

Update package ejabberd to version 19.05
Changelog - https://blog.process-one.net/ejabberd-19-05/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 1, 2019

@GrahamcOfBorg build ejabberd
@GrahamcOfBorg test ejabberd

@ofborg ofborg bot requested review from abbradar and svanderburg June 1, 2019 16:43
@abbradar
Copy link
Member

abbradar commented Jun 1, 2019

It builds; I don't have ejabberd servers running nowadays so can't check further. Did anyone try this with a running server?

@Izorkin
Copy link
Contributor Author

Izorkin commented Jun 1, 2019

Checked in my server - worked.

@abbradar abbradar merged commit cecfd06 into NixOS:master Jun 1, 2019
@abbradar
Copy link
Member

abbradar commented Jun 1, 2019

@Izorkin Thanks!

@Izorkin Izorkin deleted the ejabberd branch June 1, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

@svanderburg svanderburg Awaiting requested review from svanderburg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Izorkin @abbradar