Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

folly: 2019.04.22.00 -> 2019.05.27.00 #62330

Merged
merged 1 commit into from Jun 1, 2019
Merged

Conversation

pierreis
Copy link
Contributor

@pierreis pierreis commented May 31, 2019

Motivation for this change

Routine version bump + add MacOS as a supported target
Builds fine on MacOS and NixOS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member

veprbl commented May 31, 2019

@GrahamcOfBorg build folly

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nix-review on x86_64-linux and x86_64-darwin

@abbradar
Copy link
Member

abbradar commented Jun 1, 2019

Builds, passes review.

@abbradar abbradar merged commit 366985e into NixOS:master Jun 1, 2019
@veprbl veprbl mentioned this pull request Jun 7, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants