Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.cryptography: 2.6.1 -> 2.7 #62332

Merged
merged 1 commit into from Jun 2, 2019
Merged

python37Packages.cryptography: 2.6.1 -> 2.7 #62332

merged 1 commit into from Jun 2, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented May 31, 2019 •
edited

Changelog:
https://cryptography.io/en/latest/changelog/#v2-7

Important changes:

  • BACKWARDS INCOMPATIBLE: We no longer distribute 32-bit manylinux1
    wheels. Continuing to produce them was a maintenance burden.
  • BACKWARDS INCOMPATIBLE: Removed the
    cryptography.hazmat.primitives.mac.MACContext interface.
    The CMAC and HMAC APIs have not changed, but they are no longer
    registered as MACContext instances.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
python37Packages.cryptography: 2.6.1 -> 2.7
77e1967 
Changelog:
https://cryptography.io/en/latest/changelog/#v2-7

Important changes:
- BACKWARDS INCOMPATIBLE: We no longer distribute 32-bit manylinux1
  wheels. Continuing to produce them was a maintenance burden.
- BACKWARDS INCOMPATIBLE: Removed the
  cryptography.hazmat.primitives.mac.MACContext interface.
  The CMAC and HMAC APIs have not changed, but they are no longer
  registered as MACContext instances.
@primeos primeos requested a review from FRidh as a code owner May 31, 2019 21:20
@primeos
Copy link
Member Author

primeos commented Jun 2, 2019

Looks good (tests + rebuilds) - should be fine :)

@primeos primeos merged commit 6d99421 into NixOS:staging Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos