Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains batch update #62331

Merged
merged 5 commits into from Jun 1, 2019
Merged

jetbrains batch update #62331

merged 5 commits into from Jun 1, 2019

Conversation

sonercirit
Copy link
Contributor

@sonercirit sonercirit commented May 31, 2019 •
edited

Motivation for this change

updated with update.pl
@c0bw3b can you take a look?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sonercirit sonercirit requested a review from edwtjo as a code owner May 31, 2019 21:14
@Ma27
Copy link
Member

Ma27 commented Jun 1, 2019

Currently building and testing all affected packages....

@Ma27
Copy link
Member

Ma27 commented Jun 1, 2019

Built and tested all affected products locally and confirmed that IDEA still works with some of my existing projects.

@Ma27 Ma27 merged commit b7d1bd8 into NixOS:master Jun 1, 2019
@Ma27
Copy link
Member

Ma27 commented Jun 1, 2019

@sonercirit thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sonercirit @Ma27