Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gzdoom: Fix wrong fluidsynth version #62538

Merged
merged 1 commit into from Jun 3, 2019
Merged

gzdoom: Fix wrong fluidsynth version #62538

merged 1 commit into from Jun 3, 2019

Conversation

Hodapp87
Copy link
Contributor

@Hodapp87 Hodapp87 commented Jun 2, 2019

Motivation for this change

gzdoom runs otherwise okay, but produces an error at startup, followed by MIDI music not working:

Could not load libfluidsynth.so.1: libfluidsynth.so.1: cannot open shared object file: No such file or directory
Could not open MIDI out device

The version of fluidsynth in buildInputs is 2.x and supplies libfluidsynth.so.2. Changing the fluidsynth version back to 1.x appears to fix this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

joachifm commented Jun 3, 2019

@GrahamcOfBorg build gzdoom

@Mic92 Mic92 merged commit 78a3654 into NixOS:master Jun 3, 2019
@Mic92
Copy link
Member

Mic92 commented Jun 3, 2019

Does this require a backport?

@Hodapp87
Copy link
Contributor Author

Hodapp87 commented Jun 3, 2019

@Mic92 It needs one for 19.03, which is where I discovered it. It looks like 058e787 moved fluidsynth from 1.x to 2.x, which is why I didn't see this on 18.09. This major version change may have broken other packages, but I am not sure how common gzdoom's approach is (loading at runtime likely via dlopen rather than linking).

Is it customary for me to do backports myself where applicable? I've only ever done PRs for master.

@joachifm
Copy link
Contributor

joachifm commented Jun 3, 2019

@Hodapp87 please open a PR against the release branch if a backport makes sense (usecherry-pick -x).

Hodapp87 pushed a commit to Hodapp87/nixpkgs that referenced this pull request Jun 3, 2019
gzdoom: Fix wrong fluidsynth version
(cherry picked from commit 78a3654)
@Mic92
Copy link
Member

Mic92 commented Jun 3, 2019

backported in a0e9a22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants