Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: e00e7bf46b82
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c528690c928d
Choose a head ref
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Jun 2, 2019

  1. Copy the full SHA
    88634bc View commit details
  2. quote the semicolon

    eggrobin committed Jun 2, 2019

    Unverified

    This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
    Copy the full SHA
    2432e63 View commit details
  3. Merge pull request #2192 from eggrobin/vswhere

    Correctly handle the case where a single Visual Studio version is installed
    eggrobin authored Jun 2, 2019
    Copy the full SHA
    c528690 View commit details
Showing with 6 additions and 6 deletions.
  1. +5 −5 build_for_benchmarking.ps1
  2. +1 −1 find_msbuild.ps1
10 changes: 5 additions & 5 deletions build_for_benchmarking.ps1
Original file line number Diff line number Diff line change
@@ -2,11 +2,11 @@ $ErrorActionPreference = "Stop"

$msbuild = &".\find_msbuild.ps1"

&$msbuild `
/t:benchmarks;Scripts\benchmark_automation `
/m `
/property:Configuration=Release `
/property:Platform=x64 `
&$msbuild `
"/t:benchmarks;Scripts\benchmark_automation" `
/m `
/property:Configuration=Release `
/property:Platform=x64 `
Principia.sln

if (!$?) {
2 changes: 1 addition & 1 deletion find_msbuild.ps1
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ $msbuildpaths = &$vswhere `
$i = 0;
foreach ($name in $names) {
if ($name.startswith("VisualStudioPreview/$version-pre.$preview.")) {
return $msbuildpaths[$i]
return ($msbuildpaths | select-object -index $i)
}
++$i
}