Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasabiwallet: init at 1.1.5 #62629

Merged
merged 1 commit into from Jun 4, 2019
Merged

wasabiwallet: init at 1.1.5 #62629

merged 1 commit into from Jun 4, 2019

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Jun 3, 2019

Motivation for this change

Init at 1.1.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut mmahut force-pushed the wasabi branch 2 times, most recently from 4592e09 to ce99c70 Compare June 3, 2019 19:29
@mmahut mmahut changed the title walletwasabi: init at 1.1.5 wasabiwallet: init at 1.1.5 Jun 4, 2019
@mmahut
Copy link
Member Author

mmahut commented Jun 4, 2019

I have renamed the package to wasabiwallet as I think it makes more sense than walletwasabi.

@tilpner
Copy link
Member

tilpner commented Jun 4, 2019

@GrahamcOfBorg build wasabiwallet

@mmahut mmahut force-pushed the wasabi branch 2 times, most recently from 810119b to 9105e80 Compare June 4, 2019 17:11
@adisbladis
Copy link
Member

@GrahamcOfBorg build wasabiwallet

@jb55
Copy link
Contributor

jb55 commented Jun 4, 2019

thanks for packaging this! the commit description looks wrong: wasabiwasabi

@mmahut
Copy link
Member Author

mmahut commented Jun 4, 2019

@jb55 good catch, thank you, brainfart during renaming :)

@adisbladis adisbladis merged commit 92c8f71 into NixOS:master Jun 4, 2019
@mmahut mmahut deleted the wasabi branch June 4, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mmahut @tilpner @adisbladis @jb55