Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.pip: 19.0.3 -> 19.1.1 #62316

Merged
merged 1 commit into from Jun 15, 2019
Merged

python.pkgs.pip: 19.0.3 -> 19.1.1 #62316

merged 1 commit into from Jun 15, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

Remove pip version warning when installing packages. I know this will cause a lot of rebuilds, sorry.

Building tensorflow from scratch, and haven't hit any issues.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
$ nix path-info -Sh /nix/store/vcdwhk6w6syjx3hwb4ifkqcrsp4w7h3j-python3.5-pip-19.1.1
/nix/store/vcdwhk6w6syjx3hwb4ifkqcrsp4w7h3j-python3.5-pip-19.1.1         102.0M

@jonringer jonringer requested a review from FRidh as a code owner May 31, 2019 15:16
@FRidh FRidh self-assigned this May 31, 2019
FRidh
FRidh requested changes May 31, 2019
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version in commit msg is incorrect

@jonringer jonringer changed the title python.pkgs.pip: 9.0.3 -> 9.1.1 python.pkgs.pip: 19.0.3 -> 19.1.1 May 31, 2019
@jonringer
Copy link
Contributor Author

@FRidh yep, sorry, still waking up

@jonringer
Copy link
Contributor Author

jonringer commented May 31, 2019 •
edited

was able to build tensorflow1.13.1 and firefox with the changes.

@jonringer
Copy link
Contributor Author

bump @FRidh , feel bad constantly bugging you

@FRidh FRidh merged commit 44eac16 into NixOS:master Jun 15, 2019
@FRidh
Copy link
Member

FRidh commented Jun 15, 2019

This was not supposed to go in so reverted it directly. It's instead in python-unstable which I'll merge in staging this weekend so hopefully we have it on master the next weekend.

@jonringer
Copy link
Contributor Author

Sounds good. Thanks for visiting again :)

@jonringer jonringer deleted the bump_pip branch June 15, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh