riemann-tools: 0.2.13 -> 0.2.14, add more config options #62607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srhb
reviewed
Jun 7, 2019
| ''; | ||
| example = ["myattribute=42"]; | ||
| }; | ||
| commandSwitches = mkOption { |
There was a problem hiding this comment.
There's some precedence for calling this extraArgs, so I think we should stick with that.
| @@ -34,8 +37,24 @@ in { | |||
| Address of the host riemann node. Defaults to localhost. | |||
| ''; | |||
| }; | |||
| attributes = mkOption { | |||
There was a problem hiding this comment.
I feel like this doesn't add a lot of value over commandSwitches (which I would prefer be called extraArgs) -- can we scrap it? Keeping NixOS modules small and simple is good for evaluation time and maintainability :)
added 2 commits
June 11, 2019 09:56
Added option "extraArgs" to forward any switches to riemann-tools.
|
Thanks for your advice @srhb |
srhb
approved these changes
Jun 11, 2019
|
Updated in #65691. |
|
@DerTim1 do you mind opening a new PR for that commit please? |
|
@mmahut Can you cherry pick the commit or do a rebase? Unfortunately I'm busy with other stuff at the moment... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update riemann-tools (minor version).
Add more NixOS config options (attributes and commandSwitches) to be able to customize the monitoring client.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)