Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brook: 20190401 -> 20190601 #62403

Merged
merged 1 commit into from Jun 4, 2019
Merged

brook: 20190401 -> 20190601 #62403

merged 1 commit into from Jun 4, 2019

Conversation

xrelkd
Copy link
Contributor

@xrelkd xrelkd commented Jun 1, 2019

Motivation for this change

Update brook to the latest release.
https://github.com/txthinking/brook/releases/tag/v20190601

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xrelkd
Copy link
Contributor Author

xrelkd commented Jun 4, 2019 •
edited

Hi! @marsam
It seems that this PR gets stuck, could you review this, if possible?
Thank you very much!

@marsam
Copy link
Contributor

marsam commented Jun 4, 2019

LGTM. just curious, how did you updated deps.nix?
@GrahamcOfBorg build brook

@xrelkd
Copy link
Contributor Author

xrelkd commented Jun 4, 2019

@marsam Thanks for the review!
I clone brook repo and run go2nix to get the newer deps.nix everytime I update brook.

@marsam marsam merged commit 743583b into NixOS:master Jun 4, 2019
@xrelkd xrelkd deleted the update/brook branch June 4, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xrelkd @marsam