Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wireguard: stable backports #62400

Merged
merged 3 commits into from Jul 3, 2019
Merged

Wireguard: stable backports #62400

merged 3 commits into from Jul 3, 2019

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Jun 1, 2019

cc @Mic92 @flokli @zx2c4

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc grahamc requested a review from infinisil as a code owner June 1, 2019 14:42
@grahamc
Copy link
Member Author

grahamc commented Jun 1, 2019

see #62325

@zx2c4
Copy link
Contributor

zx2c4 commented Jun 1, 2019

👍

If you want to backport the retries=infinity thing, you could also just add that to the existing systemd unit, but without your fancy new unit-per-peer stuff that probably shouldn't be backported.

@ofborg ofborg bot requested a review from Mic92 June 1, 2019 15:39
@grahamc grahamc merged commit 7152cb2 into NixOS:release-19.03 Jul 3, 2019
@grahamc grahamc deleted the wireguard-stable-backports branch July 3, 2019 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grahamc @zx2c4 @Mic92