Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.klein: fix build/tests #62402

Merged
merged 1 commit into from Jun 1, 2019

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 1, 2019

Motivation for this change

Guess it broke when checkInputs became more strict, the further werkzeug-related breakage sneaking in after that without anyone noticing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner June 1, 2019 15:09
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.klein python3Packages.klein python36Packages.klein python35Packages.klein

@worldofpeace
Copy link
Contributor

Thanks @risicle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants