New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cura: 4.0.0 -> 4.1.0 #62374
cura: 4.0.0 -> 4.1.0 #62374
Conversation
@@ -20,8 +20,7 @@ buildPythonPackage rec { | |||
buildInputs = [ protobuf ]; | |||
|
|||
postPatch = '' | |||
# To workaround buggy SIP detection which overrides PYTHONPATH | |||
sed -i '/SET(ENV{PYTHONPATH}/d' cmake/FindSIP.cmake | |||
sed -i 's#''${Python3_SITELIB}#${placeholder "out"}/${python.sitePackages}#' cmake/SIPMacros.cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FRidh Do you know the proper way to get the python site-packages directory in cmake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is a better way short of patching CMake's FindPython
, and even that is questionable because it uses standard Python's sysconfig
to get these paths and some packages may (rightfully) expect SITELIB
to be Python's core site-packages. The root of the problem is that Python on FHS systems has only one true site-packages
and everything expects that.
@GrahamcOfBorg eval |
Tested on Linux, builds and runs. Thanks! |
Motivation for this change
New cura version. cc maintainer @abbradar
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)