Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc: add bash to buildInputs #62553

Merged
merged 1 commit into from Jun 4, 2019

Conversation

matthewbauer
Copy link
Member

@matthewbauer matthewbauer commented Jun 3, 2019

Fixes #62417

With strictdeps, we need bash to be in build inputs to get the cross built bash.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK. Tested on ghc.x86_64-linux.

@matthewbauer matthewbauer changed the base branch from master to staging June 4, 2019 00:07
@matthewbauer
Copy link
Member Author

as we do not add bash to buildInputs in stdenv.mkDerivation in order to fix 5-10 derivations, why we have done that with perl and buildPerlPackage in #61631?

Bash is normally available in patchShebangs because it is already part of stdenv and included in HOST_PATH. That won't for cross compiling but it's worth supporting to avoid breaking lots of things. it's not available when you set strictDeps = true though. Runtime Perl seems reasonable to make available in the cross case.

@matthewbauer matthewbauer merged commit 84e34cb into NixOS:staging Jun 4, 2019
peti pushed a commit that referenced this pull request Jun 4, 2019
peti pushed a commit that referenced this pull request Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants