Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

purescript: 0.12.5 -> 0.13.0 #62326

Closed
wants to merge 2 commits into from
Closed

purescript: 0.12.5 -> 0.13.0 #62326

wants to merge 2 commits into from

Conversation

srghma
Copy link
Contributor

@srghma srghma commented May 31, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srghma srghma mentioned this pull request May 31, 2019
Closed
@marsam marsam mentioned this pull request Jun 3, 2019
Merged
10 tasks
@Profpatsch
Copy link
Member

Is there no existing update.sh code in nixpkgs we can use here? I don’t think it makes much sense to add the script just for this one package.

@srghma
Copy link
Contributor Author

srghma commented Jun 4, 2019 •
edited

@Profpatsch do you think we could extract update logic from some update.sh scripts here? https://github.com/NixOS/nixpkgs/search?q=filename%3Aupdate.sh&unscoped_q=filename%3Aupdate.sh

btw, nixpkgs-mozilla update packages like this:

  1. https://github.com/mozilla/nixpkgs-mozilla/blob/2ff87ba7e9c2cea747a88545dfe13702e7386628/pkgs/servo/default.nix#L96-L101
  2. https://github.com/mozilla/nixpkgs-mozilla/blob/2ff87ba7e9c2cea747a88545dfe13702e7386628/pkgs/lib/update.nix#L7
  3. https://github.com/mozilla/nixpkgs-mozilla/blob/2ff87ba7e9c2cea747a88545dfe13702e7386628/update.nix#L110 (N.B. this is copy of https://github.com/NixOS/nixpkgs/blob/master/maintainers/scripts/update.nix )

@teto
Copy link
Member

teto commented Oct 8, 2019

Merged an update in #67875.

@teto teto closed this Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srghma @Profpatsch @teto