Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: d20bfc72cb0e
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: d9238d723bbb
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on May 31, 2019

  1. tmux module: Fix escaping in TMUX_TMPDIR 

    5404595 relocated code but kept
one backslah too many, leading to

	$ tmux
	error creating /run/user/$(id -u)/tmux-1000 (No such file or directory)

/run/user/$UID/ is created by pam_systemd(3) which also populates
XD_RUNTIME_DIR with that value.

Alternatively, TMUX_TMPDIR might simply default to XDG_RUNTIME_DIR
without providing the same directory yet again as default string in
parameter substitution, however such behaviour change is subject to
another patch.

In fact, with `security.polkit.enable = false` systemd_logind(8) fails
to start and /run/user/$UID/ is never created for unprivileged users
in proper login sessions;  XDG_RUNTIME_DIR would consequently not be
set either.

Removing the fallback to /run/user/$UID/ would have caused TMUX_TMPDIR
to be empty, which in turn would lead tmux(1) to use /tmp/.  This
effectively breaks the idea of isolated sockets entirely while hiding
errors from the user.
    @klemensn @andir
    klemensn authored and andir committed May 31, 2019
    Copy the full SHA
    7f104aa View commit details
    Browse the repository at this point in the history

  2. Merge pull request #62136 from flokli/tmux-tmpdir 

    tmux module: Fix escaping in TMUX_TMPDIR
    @andir
    andir committed May 31, 2019
    Copy the full SHA
    d9238d7 View commit details
    Browse the repository at this point in the history