Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-wireguard-exporter: init at 2.0.1 #62452

Merged
merged 1 commit into from Jun 7, 2019
Merged

prometheus-wireguard-exporter: init at 2.0.1 #62452

merged 1 commit into from Jun 7, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 2, 2019 •
edited

Motivation for this change

This is a simple exporter which exports the information
provided by wg show all dump to prometheus.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz fpletz self-requested a review June 2, 2019 01:20
@fpletz
Copy link
Member

fpletz commented Jun 2, 2019

cc @WilliButz

@Ma27 Ma27 force-pushed the package-wireguard-prometheus-exporter branch from 4efe863 to 2d6e32a Compare June 2, 2019 12:18
@Ma27
Copy link
Member Author

Ma27 commented Jun 2, 2019

After chatting with @WilliButz we decided that the use of a second peer for the wireguard testcase is probably not needed as we only check if the exporter properly retrieves metrics from the configured wireguard interface.

@Ma27 Ma27 force-pushed the package-wireguard-prometheus-exporter branch from 2d6e32a to 155c91e Compare June 2, 2019 12:24
WilliButz
WilliButz approved these changes Jun 2, 2019
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@WilliButz
Copy link
Member

@GrahamcOfBorg test prometheus-exporters.wireguard

@Ma27 Ma27 changed the title prometheus-wireguard-exporter: init at 2.0.0 WIP prometheus-wireguard-exporter: init at 2.0.0 Jun 2, 2019
@Ma27
Copy link
Member Author

Ma27 commented Jun 2, 2019

After deploying this onto some more of my machines I realized that this exporter will break if the peer's endpoint address is an IPv6 address. I've declared this as WIP for now and try to fix it later that day.

@Ma27 Ma27 force-pushed the package-wireguard-prometheus-exporter branch from 76c3eb7 to a519345 Compare June 2, 2019 20:23
@Ma27 Ma27 changed the title WIP prometheus-wireguard-exporter: init at 2.0.0 prometheus-wireguard-exporter: init at 2.0.0 Jun 2, 2019
@Ma27 Ma27 changed the title prometheus-wireguard-exporter: init at 2.0.0 WIP prometheus-wireguard-exporter: init at 2.0.0 Jun 5, 2019
@Ma27
Copy link
Member Author

Ma27 commented Jun 5, 2019

Temporarily marking this as WIP as there's now 2.0.1 which incorporates my IPv6 patch. I'll update this PR tomorrow.

@Ma27 Ma27 force-pushed the package-wireguard-prometheus-exporter branch from a519345 to b30ce66 Compare June 7, 2019 15:40
@Ma27 Ma27 changed the title WIP prometheus-wireguard-exporter: init at 2.0.0 prometheus-wireguard-exporter: init at 2.0.0 Jun 7, 2019
@Ma27 @fpletz
prometheus-wireguard-exporter: init at 2.0.1
bf09e6a 
This is a simple exporter which exports the information
provided by `wg show all dump` to prometheus.

Co-authored-by: Franz Pletz <fpletz@fnordicwalking.de>
@Ma27 Ma27 force-pushed the package-wireguard-prometheus-exporter branch from b30ce66 to bf09e6a Compare June 7, 2019 15:40
@Ma27 Ma27 changed the title prometheus-wireguard-exporter: init at 2.0.0 prometheus-wireguard-exporter: init at 2.0.1 Jun 7, 2019
@Ma27
Copy link
Member Author

Ma27 commented Jun 7, 2019

@GrahamcOfBorg build prometheus-wireguard-exporter

@Ma27
Copy link
Member Author

Ma27 commented Jun 7, 2019

@GrahamcOfBorg test prometheus-exporters.wireguard

@fpletz fpletz merged commit 3827343 into NixOS:master Jun 7, 2019
@Ma27 Ma27 deleted the package-wireguard-prometheus-exporter branch June 7, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @fpletz @WilliButz