ocamlPackages.opium: init at 0.17.1 #62455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarice
reviewed
Jun 6, 2019
|
|
||
| buildDunePackage rec { | ||
| pname = "opium"; | ||
| inherit (opium_kernel) version src meta minimumOCamlVersion; |
There was a problem hiding this comment.
what is the difference between these two packages, one just seems to have more build inputs
There was a problem hiding this comment.
It's just how upstream has organized things. Following examples like cohttp where a single source is used in multiple derivations.
vbgl
requested changes
Jul 2, 2019
|
@GrahamcOfBorg build ocamlPackages.opium |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
To use opium ocaml library (and hmap, a dependency of opium)
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)