pythonPackages.django_silk: fix build, enable tests #62544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Noticed
django-silk
has been broken since its last auto-bump. Fixed that by addinggprof2dot
topropagatedBuildInputs
, but this had the side effect of disabling the package for darwin. Fortunately I realized thatgprof2dot
does indeed work on darwin, and to prove this I enabled its tests and removed the linux restriction.Finally I enabled the tests for
django-silk
and added myself as maintainer in the hopes it doesn't get so neglected again (I think I might have added it in the first place after all...).Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)