[Gecko Bug 1555704] webdriver: add simple cross-origin WPT tests #17141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds two simple cross-origin WPT tests for WebDriver, testing that WebDriver's Switch To Frame command can transcend frames from different site origins. The justification for adding these tests to WPT is two-fold: firstly, browsers enforce strict cross-origin checks on frames and we should test for that scenario; but secondly, and perhaps more importantly, modern browsers are moving towards process isolation on a site-origin basis and this is expected to cause problems for WebDriver. Testing this behaviour will ensure any attempts at switching on process isolation on site-origin basis (i.e. "Fission") will test WebDriver's behaviour. Differential Revision: https://phabricator.services.mozilla.com/D33458 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1555704 gecko-commit: 8f179514723d391b75c6388dc4b73719c6e93508 gecko-integration-branch: autoland gecko-reviewers: webdriver-reviewers, whimboo
wpt-pr-bot
approved these changes
Jun 3, 2019
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 18, 2019
Namely, `doc_root` and `domains` (the latter was added in web-platform-tests/wpt#17141) Also a drive-by fix to improve test discovery (only run .py files). Bug: 974877 Change-Id: Idb917ee0dcab9691709e3d99e3f29ceec82edeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664042 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#670227}
T3-M4
pushed a commit
to bayandin/chromedriver
that referenced
this pull request
Jun 19, 2019
Namely, `doc_root` and `domains` (the latter was added in web-platform-tests/wpt#17141) Also a drive-by fix to improve test discovery (only run .py files). Bug: 974877 Change-Id: Idb917ee0dcab9691709e3d99e3f29ceec82edeb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664042 Reviewed-by: John Chen <johnchen@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#670227}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two simple cross-origin WPT tests for WebDriver, testing
that WebDriver's Switch To Frame command can transcend frames from
different site origins.
The justification for adding these tests to WPT is two-fold: firstly,
browsers enforce strict cross-origin checks on frames and we should
test for that scenario; but secondly, and perhaps more importantly,
modern browsers are moving towards process isolation on a site-origin
basis and this is expected to cause problems for WebDriver.
Testing this behaviour will ensure any attempts at switching on
process isolation on site-origin basis (i.e. "Fission") will test
WebDriver's behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D33458
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1555704
gecko-commit: 8f179514723d391b75c6388dc4b73719c6e93508
gecko-integration-branch: autoland
gecko-reviewers: webdriver-reviewers, whimboo