Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: solvespace/solvespace
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 9ac55f392aea
Choose a base ref
...
head repository: solvespace/solvespace
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 3d80062b66b1
Choose a head ref
  • 2 commits
  • 8 files changed
  • 1 contributor

Commits on May 31, 2019

  1. Update q3d submodule.

    whitequark committed May 31, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    Mic92 Jörg Thalheim
    Copy the full SHA
    3596979 View commit details
  2. GTK: delete all gtkmm objects before destrying Gtk::Main.

    Otherwise this results in harmless but annoying spam on applciation
    shutdown.
    
    See https://gitlab.gnome.org/GNOME/gtkmm/issues/22.
    whitequark committed May 31, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    Mic92 Jörg Thalheim
    Copy the full SHA
    3d80062 View commit details
Showing with 14 additions and 4 deletions.
  1. +1 −1 extlib/q3d
  2. +2 −2 src/export.cpp
  3. +1 −1 src/platform/entrygui.cpp
  4. +1 −0 src/platform/gui.h
  5. +3 −0 src/platform/guigtk.cpp
  6. +2 −0 src/platform/guimac.mm
  7. +2 −0 src/platform/guinone.cpp
  8. +2 −0 src/platform/guiwin.cpp
2 changes: 1 addition & 1 deletion extlib/q3d
Submodule q3d updated 3 files
+16 −8 CMakeLists.txt
+8 −0 README.md
+0 −0 q3d_object.fbs
4 changes: 2 additions & 2 deletions src/export.cpp
Original file line number Diff line number Diff line change
@@ -94,7 +94,7 @@ void SolveSpaceUI::ExportSectionTo(const Platform::Path &filename) {
// Remove all overlapping edges/beziers to merge the areas they describe.
el.CullExtraneousEdges(/*both=*/true);
bl.CullIdenticalBeziers(/*both=*/true);

// Collect lines and beziers with custom style & export.
int i;
for(i = 0; i < SK.entity.n; i++) {
@@ -900,7 +900,7 @@ void SolveSpaceUI::ExportMeshAsStlTo(FILE *f, SMesh *sm) {
// Export the mesh as a Q3DO (https://github.com/q3k/q3d) file.
//-----------------------------------------------------------------------------

#include "object_generated.h"
#include "q3d_object_generated.h"
void SolveSpaceUI::ExportMeshAsQ3doTo(FILE *f, SMesh *sm) {
flatbuffers::FlatBufferBuilder builder(1024);
double s = SS.exportScale;
2 changes: 1 addition & 1 deletion src/platform/entrygui.cpp
Original file line number Diff line number Diff line change
@@ -29,8 +29,8 @@ int main(int argc, char** argv) {

Platform::Close3DConnexion();
SS.Clear();

SK.Clear();
Platform::ClearGui();

return 0;
}
1 change: 1 addition & 0 deletions src/platform/gui.h
Original file line number Diff line number Diff line change
@@ -380,6 +380,7 @@ void OpenInBrowser(const std::string &url);
void InitGui(int argc, char **argv);
void RunGui();
void ExitGui();
void ClearGui();

}

3 changes: 3 additions & 0 deletions src/platform/guigtk.cpp
Original file line number Diff line number Diff line change
@@ -1475,6 +1475,9 @@ void RunGui() {

void ExitGui() {
gtkMain->quit();
}

void ClearGui() {
delete gtkMain;
}

2 changes: 2 additions & 0 deletions src/platform/guimac.mm
Original file line number Diff line number Diff line change
@@ -1479,5 +1479,7 @@ void ExitGui() {
[NSApp terminate:nil];
}

void ClearGui() {}

}
}
2 changes: 2 additions & 0 deletions src/platform/guinone.cpp
Original file line number Diff line number Diff line change
@@ -154,6 +154,8 @@ void ExitGui() {
exit(0);
}

void ClearGui() {}

}

}
2 changes: 2 additions & 0 deletions src/platform/guiwin.cpp
Original file line number Diff line number Diff line change
@@ -1677,5 +1677,7 @@ void ExitGui() {
PostQuitMessage(0);
}

void ClearGui() {}

}
}