Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add libcoap #62320

Merged
merged 2 commits into from Jun 1, 2019
Merged

add libcoap #62320

merged 2 commits into from Jun 1, 2019

Conversation

kmein
Copy link
Member

@kmein kmein commented May 31, 2019

Motivation for this change

libcoap was missing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

@GrahamcOfBorg build libcoap

jtojnar
jtojnar requested changes May 31, 2019
View reviewed changes
pkgs/applications/networking/libcoap/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/libcoap/default.nix Outdated Show resolved Hide resolved
@kmein kmein force-pushed the master branch 2 times, most recently from ad6f713 to e907f3c Compare June 1, 2019 18:42
@Lassulus
Copy link
Member

Lassulus commented Jun 1, 2019

tested with nix-review, seems to work

@Lassulus Lassulus merged commit eb8a9f6 into NixOS:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus left review comments

@jtojnar jtojnar jtojnar requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmein @Lassulus @jtojnar