Skip to content

octoprint: 1.3.10 -> 1.3.11 #62321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 1, 2019
Merged

octoprint: 1.3.10 -> 1.3.11 #62321

merged 6 commits into from
Jun 1, 2019
+75 −23

Conversation

gebner
Copy link
Member

@gebner gebner commented May 31, 2019

Motivation for this change

The cura slicer plugin is now no longer bundled, you need to add it manually to services.octoprint.plugins.

Tested on aarch64, prints fine.

cc maintainer @abbradar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@gebner gebner requested a review from FRidh as a code owner May 31, 2019 17:47
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package labels May 31, 2019
@ofborg ofborg bot requested a review from abbradar May 31, 2019 18:01
abbradar
abbradar reviewed Jun 1, 2019
View reviewed changes
pkgs/applications/misc/octoprint/plugins.nix
@@ -104,6 +104,25 @@ let
};
};

curaenginelegacy = buildPlugin rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, if it's named legacy I guess they finally implemented a plugin for new curaengine too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately no, as far as I can tell. They just decided to get rid of the ancient cura version.

@gebner gebner merged commit a40660a into NixOS:master Jun 1, 2019
@abbradar
Copy link
Member

abbradar commented Jun 1, 2019

Ah, I still had nox-review running. There is some breakage due to markdown update but seems nothing serious.

@gebner
Copy link
Member Author

gebner commented Jun 1, 2019

Oops, forgot about that. What packages are broken?

@abbradar
Copy link
Member

abbradar commented Jun 1, 2019

I'll say when I get home again :D I remember MarkdownSuperscript.

@gebner
Copy link
Member Author

gebner commented Jun 1, 2019

Ok, MarkdownSuperscript is now fixed in 879a5c8 Luckily, nothing depends on it.

@gebner
Copy link
Member Author

gebner commented Jun 1, 2019

Nikola and pelican are also fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gebner @abbradar