Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/prometheus-fritzbox-exporter: update binary name #62322

Merged
merged 1 commit into from May 31, 2019

Conversation

WilliButz
Copy link
Member

Motivation for this change

Updates the module to use the correct binary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @flokli

@flokli
Copy link
Contributor

flokli commented May 31, 2019

you're right - missed that during #60857, sorry!

@flokli flokli merged commit 3758b39 into NixOS:master May 31, 2019
@WilliButz WilliButz deleted the fix-fritzbox-exporter-service branch May 31, 2019 20:04
@WilliButz
Copy link
Member Author

Just noticed it because I was refactoring the prometheus exporter tests :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants