Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hplip: add aarch64-linux to platforms #62334

Merged
merged 2 commits into from Jun 3, 2019
Merged

hplip: add aarch64-linux to platforms #62334

merged 2 commits into from Jun 3, 2019

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented May 31, 2019

EDIT: I think it works now...

Motivation for this change

Tried to use this package for my printer and it took 'forever' to build (I canceled after 30+ minutes when one thing was at 7% and I gave up and used gutenprint). Had to use the arm build server to be able to try it. Thanks, @grahamc !

Things done

I built it on the arm build server from my raspberry pi 3 B and printed a test page with it. I can't figure out how to get nix-review to do anything with; it just says 'Nothing changed'.

EDIT: aarch64 is broken in newer versions. I've added it to the old old version in nixpkgs we already have, added the latest version from 18.09 which is one of, if not the last, version it worked on afaik. That's the version my pi was on and why it worked there... This time I've actually compiled all of them. >.>

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from ttuegel May 31, 2019 22:38
@Kiwi Kiwi changed the title hplip: add aarch64-linux to platforms WIP: hplip: add aarch64-linux to platforms May 31, 2019
@Kiwi Kiwi force-pushed the hplip branch 2 times, most recently from fc18b48 to d2ecc24 Compare June 1, 2019 04:26
@Kiwi Kiwi changed the title WIP: hplip: add aarch64-linux to platforms hplip: add aarch64-linux to platforms Jun 1, 2019
@ofborg ofborg bot requested a review from jgeerds June 1, 2019 04:32
@matthewbauer matthewbauer merged commit cfec14e into NixOS:master Jun 3, 2019
@Kiwi Kiwi deleted the hplip branch June 20, 2019 22:38
@mebubo mebubo mentioned this pull request Jun 29, 2019
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants