Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paperkey: use HTTPS #62600

Merged
merged 1 commit into from Jun 3, 2019
Merged

paperkey: use HTTPS #62600

merged 1 commit into from Jun 3, 2019

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jun 3, 2019 •
edited

Motivation for this change

Especially important for a security tool!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@joachifm
Copy link
Contributor

joachifm commented Jun 3, 2019

Makes sense to update meta.homepage as well.

@Mic92 Mic92 merged commit 96ec038 into NixOS:master Jun 3, 2019
@Mic92
Copy link
Member

Mic92 commented Jun 3, 2019 •
edited

[detached HEAD 0a99c65] paperkey: use HTTPS
Author: Lorenzo Manacorda lorenzo@mailbox.org
Date: Mon Jun 3 12:51:25 2019 +0200
1 file changed, 2 insertions(+), 2 deletions(-)

@asymmetric asymmetric deleted the paperkey branch June 3, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asymmetric @joachifm @Mic92