Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tora: fix build #62398

Closed
wants to merge 1 commit into from
Closed

tora: fix build #62398

wants to merge 1 commit into from

Conversation

knedlsepp
Copy link
Member

Motivation for this change

We need to bump to latest unstable to fix the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp changed the title Fix tora build tora: fix build Jun 1, 2019
@knedlsepp
Copy link
Member Author

@GrahamcOfBorg build tora

@ofborg ofborg bot requested a review from peterhoeg June 1, 2019 15:02
@worldofpeace
Copy link
Contributor

Yeah they really should think about making a release tora-tool/tora#132

worldofpeace
worldofpeace reviewed Jun 1, 2019
View reviewed changes
pkgs/development/tools/tora/default.nix
@@ -6,13 +6,13 @@ let

in mkDerivation rec {
name = "tora-${version}";
version = "3.1";
version = "unstable-2019-04-10";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a release it's just not tagged tora-tool/tora@39bf283

@aanderse
Copy link
Member

aanderse commented Sep 1, 2019

@knedlsepp any motivation to continue with this PR?

@peterhoeg
Copy link
Member

We already have a newer version in staging.

@peterhoeg peterhoeg closed this Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace left review comments

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knedlsepp @worldofpeace @aanderse @peterhoeg