Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purescript: upgrade to 0.13.0 #62580

Merged
merged 1 commit into from Jun 4, 2019
Merged

Conversation

justinwoo
Copy link
Member

purescript: 0.12.5 -> 0.13.0

https://github.com/purescript/purescript/releases/v0.13.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
Copy link
Contributor

marsam commented Jun 3, 2019

Duplicate of #62326

@marsam marsam marked this as a duplicate of #62326 Jun 3, 2019
@justinwoo
Copy link
Member Author

@marsam That PR seems to try to rewrite everything. This PR is simply a version bump similar to #59589.

@srghma
Copy link
Contributor

srghma commented Jun 4, 2019

That PR seems to try to rewrite everything

the update.sh is used a lot in nixpkgs https://github.com/NixOS/nixpkgs/search?q=filename%3Aupdate.sh&unscoped_q=filename%3Aupdate.sh

N.B. though I should say, my pr https://github.com/NixOS/nixpkgs/pull/62326/files is not completely right - I should consider adding passthru.updateScript = ./update.sh (more ryantm/nixpkgs-update#117 (comment))

@Profpatsch
Copy link
Member

Let’s bump first and then think about automating the update.

@Profpatsch
Copy link
Member

@GrahamcOfBorg build purescript

@Profpatsch Profpatsch merged commit 2b1eabc into NixOS:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants