pythonPackages.scikit-build: fix by bumping pytest-virtualenv, -shutil, -fixture-config, -server-fixtures #62445
+21
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
scikit-build
appears to have broken whenpytest
was bumped to 4.x. However the only thing complaining about the presence of pytest4 was one of its dependencies,pytest-virtualenv
. So what I did instead was bump that along withpytest-shutil
,pytest-fixture-config
andpytest-server-fixtures
because they all actually come from the same "master package" https://github.com/manahl/pytest-plugins and all have a recent 1.7.0 release which makes them compatible with pytest4 and allows me to remove anypytest_3
requirement for them.Finally I had to disable
test_source_distribution
inscikit-build
to get its tests to pass. Previously I think it had actually been auto-skipping this test so I don't think I'm actually net disabling anything.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)