Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.scikit-build: fix by bumping pytest-virtualenv, -shutil, -fixture-config, -server-fixtures #62445

Closed
wants to merge 5 commits into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jun 1, 2019

Motivation for this change

scikit-build appears to have broken when pytest was bumped to 4.x. However the only thing complaining about the presence of pytest4 was one of its dependencies, pytest-virtualenv. So what I did instead was bump that along with pytest-shutil, pytest-fixture-config and pytest-server-fixtures because they all actually come from the same "master package" https://github.com/manahl/pytest-plugins and all have a recent 1.7.0 release which makes them compatible with pytest4 and allows me to remove any pytest_3 requirement for them.

Finally I had to disable test_source_distribution in scikit-build to get its tests to pass. Previously I think it had actually been auto-skipping this test so I don't think I'm actually net disabling anything.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jun 15, 2019

Included in #63169

@FRidh FRidh closed this Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants