Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gzdoom: Fix wrong fluidsynth version (backport to 19.03) #62615

Closed
wants to merge 1 commit into from
Closed

gzdoom: Fix wrong fluidsynth version (backport to 19.03) #62615

wants to merge 1 commit into from

Conversation

Hodapp87
Copy link
Contributor

@Hodapp87 Hodapp87 commented Jun 3, 2019

Motivation for this change

Same as #62538, but a backport of 78a3654 to 19.03, which has the same problem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 @Hodapp87
Merge pull request NixOS#62538 from Hodapp87/master
83fd084 
gzdoom: Fix wrong fluidsynth version
(cherry picked from commit 78a3654)
@Mic92
Copy link
Member

Mic92 commented Jun 3, 2019

Race condition. I already pushed: a0e9a22

@Mic92 Mic92 closed this Jun 3, 2019
@ofborg ofborg bot requested a review from Lassulus June 3, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Awaiting requested review from Lassulus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hodapp87 @Mic92