Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gecko Bug 1533877] Add web-platform tests for the Cross-Origin header #17145

Merged
merged 5 commits into from Jun 12, 2019

Conversation

moz-wptsync-bot
Copy link
Collaborator

Differential Revision: https://phabricator.services.mozilla.com/D31398

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1533877
gecko-commit: e53056e11429f1342f867edb37ef021b86405b66
gecko-integration-branch: autoland
gecko-reviewers: annevk

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

Differential Revision: https://phabricator.services.mozilla.com/D31398

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1533877
gecko-commit: 50c186027c4574aa2cee312c3cd7e538898f9787
gecko-integration-branch: autoland
gecko-reviewers: annevk
Differential Revision: https://phabricator.services.mozilla.com/D32972

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1533877
gecko-commit: 83e3f3d5b47392432c9b8d2fcb04005cdcc52dbe
gecko-integration-branch: autoland
gecko-reviewers: nika
Differential Revision: https://phabricator.services.mozilla.com/D32973

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1533877
gecko-commit: 3db99e5835d3d0c30719f2072f2efeb68c158d71
gecko-integration-branch: autoland
gecko-reviewers: annevk
Differential Revision: https://phabricator.services.mozilla.com/D32974

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1533877
gecko-commit: 68a98bde7e6c368fa9974596e8133b35f28a7d13
gecko-integration-branch: autoland
gecko-reviewers: annevk
…he opener is closed

Differential Revision: https://phabricator.services.mozilla.com/D32975

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1533877
gecko-commit: f9e0344a5fc19046003c299a4b0cdd1d8eaaec2a
gecko-integration-branch: autoland
gecko-reviewers: annevk
@jgraham
Copy link
Contributor

jgraham commented Jun 12, 2019

On'y failing firefox stability checks so I'm going to force-merge.

@jgraham jgraham merged commit 8b045d6 into master Jun 12, 2019
@moz-wptsync-bot moz-wptsync-bot deleted the gecko/1533877 branch June 12, 2019 20:41
@foolip
Copy link
Member

foolip commented Jun 17, 2019

FYI, there was a problem with this test in Chromium:
https://bugs.chromium.org/p/chromium/issues/detail?id=974334

@jgraham
Copy link
Contributor

jgraham commented Jun 17, 2019

Is a Failure a problem that means it shouldn't have merged? Unless I'm misreading your bug tracker, it doesn't look like it was marked as unstable.

@foolip
Copy link
Member

foolip commented Jun 17, 2019

I'm actually not sure if it's flaky, I tried to work that out but don't know where to look in https://test-results.appspot.com/dashboards/flakiness_dashboard.html anymore. Since CI passed here except for Firefox I think merging it was correct, just linking the bugs together in case something interesting comes out of the Chromium bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants