Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caja-dropbox: fix python dependency #62617

Merged
merged 1 commit into from Jun 11, 2019
Merged

Conversation

alexarice
Copy link
Contributor

Motivation for this change

Fixes #62612
This seems to fix the issue though I don't know much about python packaging so I don't know if what I have done is correct.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
Copy link
Contributor

romildo commented Jun 4, 2019

@GrahamcOfBorg build mate.caja-dropbox

Copy link
Contributor

@romildo romildo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure local build succeeded
  • run nix-review without any failures

@jtojnar
Copy link
Contributor

jtojnar commented Jun 4, 2019

Perhaps you might not want pygobject except for build (see #60752)

@alexarice
Copy link
Contributor Author

Perhaps you might not want pygobject except for build (see #60752)

So pygobject and gobject-introspection should be in native build inputs?

@jtojnar
Copy link
Contributor

jtojnar commented Jun 4, 2019

If the package is synchronized with nautilus-dropbox (dropbox-cli in Nixpkgs). I did not actually checked the fork did not diverge.

@alexarice
Copy link
Contributor Author

I don't know much about the project, I just added things until it built. I know that pygobject and gobject-introspection are definitely needed during the build.

@alexarice
Copy link
Contributor Author

The packages look virtually identical so I have the changed the dependencies to look like nautilus-dropbox

@ofborg ofborg bot requested a review from romildo June 5, 2019 17:34
@alexarice
Copy link
Contributor Author

@romildo @jtojnar is this ok now?

@jtojnar
Copy link
Contributor

jtojnar commented Jun 5, 2019

Hmm, the package actually does not obtain Dropbox from Nix. Either it needs to do so with a patch like nautilus-dropbox does, or it will require pygobject & gtk at runtime to download it.

@alexarice
Copy link
Contributor Author

I'll include a patch

@alexarice
Copy link
Contributor Author

Hopefully this is fixed now though I don't really know a good way to test if an input was correctly put as a nativeBuildInput or buildInput

@jtojnar
Copy link
Contributor

jtojnar commented Jun 5, 2019

You can add strictDeps = true to the derivation to enable the distinction.

@alexarice
Copy link
Contributor Author

It all works with strictDeps on, should I include strictDeps in the derivation or is it unnecessary

@alexarice
Copy link
Contributor Author

I have put in the strictDeps = true line as it everything appears to work correctly with it there

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/16

@romildo romildo merged commit 7f6f5e0 into NixOS:master Jun 11, 2019
@alexarice alexarice deleted the caja-dropbox branch June 11, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caja dropbox does not build
4 participants