New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
caja-dropbox: fix python dependency #62617
Conversation
@GrahamcOfBorg build mate.caja-dropbox |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- reviewed the diff and commit messages
- made sure local build succeeded
- run nix-review without any failures
Perhaps you might not want pygobject except for build (see #60752) |
So pygobject and gobject-introspection should be in native build inputs? |
If the package is synchronized with |
I don't know much about the project, I just added things until it built. I know that pygobject and gobject-introspection are definitely needed during the build. |
The packages look virtually identical so I have the changed the dependencies to look like |
Hmm, the package actually does not obtain Dropbox from Nix. Either it needs to do so with a patch like |
I'll include a patch |
d447447
to
39c1685
Compare
Hopefully this is fixed now though I don't really know a good way to test if an input was correctly put as a nativeBuildInput or buildInput |
You can add |
It all works with strictDeps on, should I include strictDeps in the derivation or is it unnecessary |
I have put in the |
This pull request has been mentioned on Nix community. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/16 |
Motivation for this change
Fixes #62612
This seems to fix the issue though I don't know much about python packaging so I don't know if what I have done is correct.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)