dropbox: fix tray menu with StatusNotifierItem trays #62595
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If dropbox can't load libappindicator, it will fallback to using the old xembed protocol. If you (or your Desktop Environment) are running something like KDE's XEmbed SNI Proxy, then you'll at least see an icon, but clicking the icon won't give you menu. Adding libappindicator to the env allows dropbox to fully integrate with contemporary status trays, while still falling back to xembed if the required DBus service is not present.
ofborg
bot
added
10.rebuild-darwin: 0
worldofpeace
approved these changes
Jun 5, 2019
|
backported to 19.03 in 1a27474 |
|
✨ Thanks for fixing this @cstrahan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
If dropbox can't load libappindicator, it will fallback to using the old
xembed protocol. If you (or your Desktop Environment) are running
something like KDE's XEmbed SNI Proxy, then you'll at least see an icon,
but clicking the icon won't give you menu.
Adding libappindicator to the env allows dropbox to fully integrate with
contemporary status trays, while still falling back to xembed if the
required DBus service is not present.
This should also be backported to (at least) the
nixos-19.03channel.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)