Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dropbox: fix tray menu with StatusNotifierItem trays #62595

Merged
merged 1 commit into from Jun 5, 2019

Conversation

cstrahan
Copy link
Contributor

@cstrahan cstrahan commented Jun 3, 2019

Motivation for this change

If dropbox can't load libappindicator, it will fallback to using the old
xembed protocol. If you (or your Desktop Environment) are running
something like KDE's XEmbed SNI Proxy, then you'll at least see an icon,
but clicking the icon won't give you menu.

Adding libappindicator to the env allows dropbox to fully integrate with
contemporary status trays, while still falling back to xembed if the
required DBus service is not present.

This should also be backported to (at least) the nixos-19.03 channel.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

If dropbox can't load libappindicator, it will fallback to using the old
xembed protocol. If you (or your Desktop Environment) are running
something like KDE's XEmbed SNI Proxy, then you'll at least see an icon,
but clicking the icon won't give you menu.

Adding libappindicator to the env allows dropbox to fully integrate with
contemporary status trays, while still falling back to xembed if the
required DBus service is not present.
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, haven't tested this though.

@worldofpeace worldofpeace merged commit 35c3396 into NixOS:master Jun 5, 2019
@worldofpeace
Copy link
Contributor

backported to 19.03 in 1a27474

@worldofpeace
Copy link
Contributor

✨ Thanks for fixing this @cstrahan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants