Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: 1.19.1 -> 1.21.1 #62428

Closed
wants to merge 1 commit into from
Closed

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jun 1, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/grpc/versions.

meta.description for grpc is: '"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)"'.

meta.homepage for grpc is: '"https://grpc.io/"

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

23 total rebuild path(s)

22 package rebuild(s)

22 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
grpc
linuxPackages-libre.sysdig
linuxPackages.sysdig
linuxPackages_4_14.sysdig
linuxPackages_4_19.sysdig
linuxPackages_4_4.sysdig
linuxPackages_4_9.sysdig
linuxPackages_5_0.sysdig
linuxPackages_5_1.sysdig
linuxPackages_hardened.sysdig
linuxPackages_hardkernel_4_14.sysdig
linuxPackages_hardkernel_latest.sysdig
linuxPackages_latest-libre.sysdig
linuxPackages_latest.sysdig
linuxPackages_latest_hardened.sysdig
linuxPackages_latest_xen_dom0.sysdig
linuxPackages_latest_xen_dom0_hardened.sysdig
linuxPackages_testing_bcachefs.sysdig
linuxPackages_testing_hardened.sysdig
linuxPackages_xen_dom0.sysdig
linuxPackages_xen_dom0_hardened.sysdig
sysdig

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/d55v6hvy2pfz8z3444ckclfj7hnhrj2r-grpc-1.21.1 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A grpc https://github.com/r-ryantm/nixpkgs/archive/bcd815eeafca8c586a0a5ab222c0680037393366.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/d55v6hvy2pfz8z3444ckclfj7hnhrj2r-grpc-1.21.1
ls -la /nix/store/d55v6hvy2pfz8z3444ckclfj7hnhrj2r-grpc-1.21.1/bin

cc @LnL7 for testing.

Verified

This commit was signed with the committer’s verified signature.
dadada Tim Schubert
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/grpc/versions
@worldofpeace
Copy link
Contributor

worldofpeace commented Jun 1, 2019

Reviewers, note that grpcio and grpcio-tools need to be the same versions when this gets bumped.
Currently they're at 1.18.0 so they should be 1.21.1 as well.

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks good, but what @worldofpeace said concerns me: Maybe we need runtime dependencies here?

@FRidh FRidh added the 2.status: work-in-progress This PR isn't done label Jun 23, 2019
@luzpaz
Copy link
Contributor

luzpaz commented Jun 24, 2019

FYI, grpc 1.21.3 is latest stable

@marsam marsam mentioned this pull request Aug 2, 2019
10 tasks
@marsam marsam closed this in #65770 Aug 4, 2019
@r-ryantm r-ryantm deleted the auto-update/grpc branch August 17, 2019 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants