Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dvc: init at 0.41.3 #62536

Closed
wants to merge 1 commit into from
Closed

dvc: init at 0.41.3 #62536

wants to merge 1 commit into from

Conversation

jeromebaum
Copy link

@jeromebaum jeromebaum commented Jun 2, 2019 •
edited

Motivation for this change

To add the "dvc" app to nixpkgs. See https://dvc.org for a description of dvc and its use-cases.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Tested execution of dvc executable but not the other binary files.
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    • I don't know how to add the meta attribute.

@jeromebaum
Copy link
Author

Looks like there's another open PR with an older version: #54530

@jeromebaum jeromebaum marked this pull request as ready for review June 4, 2019 18:38
@worldofpeace
Copy link
Contributor

As far as I can tell we don't accept packages using pypi2nix in nixpkgs.
Perhaps you could complete #54530 which uses buildPython*.

nixpkgs manual on python packaging
https://nixos.org/nixpkgs/manual/#python

@jeromebaum
Copy link
Author

No worries. I'm closing this in favor of #54530 and I'll just wait and see if the authors on that complete it. Thanks.

@jeromebaum jeromebaum closed this Jun 5, 2019
@CMCDragonkai
Copy link
Member

Hey @jeromebaum I don't have time to finish #54530, can you take over that. There's just one change I think the reviewer wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeromebaum @worldofpeace @CMCDragonkai @Janik-Haag