Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documize-community: 2.5.0 -> 2.5.1 #62605

Merged
merged 1 commit into from Jun 7, 2019
Merged

documize-community: 2.5.0 -> 2.5.1 #62605

merged 1 commit into from Jun 7, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jun 3, 2019 •
edited

Motivation for this change

See https://github.com/documize/community/releases/tag/v2.5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member Author

Ma27 commented Jun 3, 2019

cc @elseym

elseym
elseym approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@elseym elseym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works flawlessly on top of current master. thanks @Ma27 :)

@Ma27
Copy link
Member Author

Ma27 commented Jun 7, 2019

Thanks for testing it out! :)

@Ma27 Ma27 merged commit 7212b33 into NixOS:master Jun 7, 2019
@Ma27 Ma27 deleted the bump-documize branch June 7, 2019 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elseym elseym elseym approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @elseym