Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-quick-stats: init at 2.0.8 #62440

Merged
merged 2 commits into from Jun 9, 2019
Merged

git-quick-stats: init at 2.0.8 #62440

merged 2 commits into from Jun 9, 2019

Conversation

kmein
Copy link
Member

@kmein kmein commented Jun 1, 2019

Motivation for this change

This package was missing from nixpkgs while for example homebrew has it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kmein kmein requested a review from FRidh as a code owner June 1, 2019 22:57
@davidak
Copy link
Member

davidak commented Jun 3, 2019

@kmein looks like a useful tool. thanks for the PR!

It seems the lyricwikia commit slipped in. Can you remove it from the branch?

@ofborg ofborg bot removed the 6.topic: python label Jun 5, 2019
@vcunat
git-quick-stats: use more idiomatic code
fa9e51d 
In particular, overriding *whole* phases isn't generally a good idea,
as you may lose various default hooks.
@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

Hmm, do the colors look OK for you? When I run just git-quick-stats, in my konsole the menu items aren't visible at all, in xterm they're barely visible but without their numbers so not really usable either.

@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

Oh, let's try darwin build, BTW.
@GrahamcOfBorg build git-quick-stats

@kmein
Copy link
Member Author

kmein commented Jun 9, 2019

For me (urxvt, dark scheme) the colours work perfectly. Maybe the author just assumed that people use a dark colorscheme?

@vcunat
Copy link
Member

vcunat commented Jun 9, 2019

Right, it seems so. I posted upstream: arzzen/git-quick-stats#65 (comment)

vcunat added a commit that referenced this pull request Jun 9, 2019
@vcunat
Merge #62440: git-quick-stats: init at 2.0.8
eae71ea 
(cherry picked from commit 2354bc6)
pull bot pushed a commit to avitex/nixpkgs that referenced this pull request Jun 9, 2019
@vcunat
Merge NixOS#62440: git-quick-stats: init at 2.0.8
2354bc6
@vcunat vcunat merged commit fa9e51d into NixOS:master Jun 9, 2019
@devhell devhell mentioned this pull request Jun 9, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmein @davidak @vcunat