calls: init at 0.0.1 #65362

craigem · 2019-07-25T01:57:52Z

Motivation for this change

The calls application is required to provide phone calls for the Librem 5 phone.

This is the initial commit for this application to be packaged for NixOS and the first step to getting NixOS to fully support the Librem 5 phone.

Things done

craigem · 2019-07-25T02:00:30Z

Resolves #65361

pkgs/applications/radio/calls/default.nix

worldofpeace · 2019-07-25T04:39:20Z

This and a lot of other Librem software has been packaged as part of #57614.

ddee3c8 looks pretty complete, perhaps out of date.

craigem · 2019-07-25T05:59:38Z

This and a lot of other Librem software has been packaged as part of #57614.

I had not found this. I'll make sure I hook everything I'm doing back into that.

Thanks!

craigem · 2019-07-25T10:27:19Z

I had a read of #57614 and note that he had put it "networking" where as I had put it in "radio".

Any thoughts on the correct location?

worldofpeace · 2019-07-27T13:49:27Z

A calling application would be a networking application. Additionally all the applications in that directory have no relation to this one.

craigem · 2019-07-28T10:37:13Z

A calling application would be a networking application. Additionally all the applications in that directory have no relation to this one.

I can see why that would be applicable, but this application is using modem manager to use operate a mobile phone radio to place phone calls across a mobile phone network.

Happy to switch this to "networking", just wanted to make it clear that this was not a VOIP application.

worldofpeace · 2019-07-28T21:34:54Z

I can see why that would be applicable, but this application is using modem manager to use operate a mobile phone radio to place phone calls across a mobile phone network.

Indeed, but I think it has fallen out of fashion to refer to those things as "radio" even though it's correct.

also

Additionally all the applications in that directory have no relation to this one.

craigem · 2019-07-29T23:42:52Z

calls has now been moved to networking.

worldofpeace

You need to call this package in all-packages.nix.

Additonally, can you match the code style of ddee3c8 and *Inputs?

Currently the dependencies are declared improperly, and we shouldn't have to reference anything under the gnome3 attribute.

craigem · 2019-07-30T00:47:32Z

Thanks for your time and input @worldofpeace

I originally based this work on how the related package, libhandy was packaged so your corrections and guidance have been helpful.

If I've understood your suggestions correctly, this last commit should be what you're looking for.

craigem · 2019-07-31T11:27:12Z

Finally bumped all-packages.nix.

nixos-discourse · 2019-08-07T21:36:13Z

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/github-label-for-prs-for-librem-5-related-packages/3653/3

pkgs/applications/networking/calls/default.nix

worldofpeace · 2019-08-23T14:25:57Z

Doesn't this need other software/services like how #57614 mentioned?
I'd think without it this wouldn't be very useful.

jtojnar · 2019-08-23T15:12:22Z

pkgs/applications/networking/calls/default.nix

+  checkInputs = [
+    dbus
+    xvfb_run
+    xlibs.xauth


Suggested change

xlibs.xauth

xorg.xauth

@lheckemann ^

jtojnar · 2019-08-23T15:13:25Z

What the heck is this commit set:

~/P/nixpkgs ((3a0f023e…)|…)
$ git hub pull checkout 65362
Fetching pull/65362/head from git@github.com:NixOS/nixpkgs.git

~/P/nixpkgs ((6e99182f…)|…)
$ git rebase channels/nixos-unstable
First, rewinding head to replay your work on top of it...
Applying: calls: Initial commit to package the application
Applying: Corrected licence
Applying: Corrected licence
Using index info to reconstruct a base tree...
M	pkgs/applications/radio/calls/default.nix
Falling back to patching base and 3-way merge...
Auto-merging pkgs/applications/radio/calls/default.nix
No changes -- Patch already applied.

~/P/nixpkgs ((07e4206a…)|…)
$ nix-build -A calls
error: attribute 'calls' in selection path 'calls' not found

lheckemann · 2019-10-31T13:07:37Z

I've pushed a version with a cleaned-up history, upgraded to a recent version from upstream git, and tested the application as far as I could (I haven't managed to bend ModemManager to my will yet, but calls seems fine). Will merge on Monday if nobody objects, or as soon as someone approves :)

worldofpeace · 2019-10-31T13:39:16Z

pkgs/applications/radio/calls/default.nix

+  nativeBuildInputs = [
+    meson ninja pkgconfig libhandy modemmanager desktop-file-utils
+  ];
+  buildInputs = [ libhandy gnome3.gsound gtk3 gnome3.libpeas gom libxml2 evolution_data_server ];


Suggested change

buildInputs = [ libhandy gnome3.gsound gtk3 gnome3.libpeas gom libxml2 evolution_data_server ];

buildInputs = [ libhandy gsound gtk3 libpeas gom libxml2 evolution-data-server ];

old aliases

worldofpeace · 2019-10-31T13:39:56Z

pkgs/applications/radio/calls/default.nix

+  };
+
+  nativeBuildInputs = [
+    meson ninja pkgconfig libhandy modemmanager desktop-file-utils


why is modemanager and libhandy native?

worldofpeace · 2019-10-31T13:41:50Z

@lheckemann This was never moved to networking #65362 (comment).

worldofpeace · 2019-10-31T13:43:53Z

@lheckemann Can we format the expression as @jtojnar https://github.com/NixOS/nixpkgs/blob/4bc5288ac9f6d99ca595433fcaf9fa4ca9fbe5a5/pkgs/applications/networking/calls/default.nix.
That's a code style we're pretty much going for. You could even push that expression manually.

lheckemann · 2019-11-01T10:37:36Z

Wow, that was a funky history. Rebase completely failed..? Anyway, here's my second cleanup attempt :)

worldofpeace · 2019-11-01T10:49:13Z

pkgs/applications/networking/calls/default.nix

+
+stdenv.mkDerivation rec {
+  pname = "calls";
+  version = "2019-10-09-unstable";


unstable in pname.

#68518

worldofpeace · 2019-11-01T10:50:29Z

pkgs/applications/networking/calls/default.nix

+  ];
+  buildInputs = [
+    libhandy
+    evolution_data_server


Suggested change

evolution_data_server

evolution-data-server

pkgs/applications/networking/calls/default.nix

worldofpeace · 2019-11-01T10:51:17Z

@lheckemann libhandy and modemanager are both sill in nativeBuildInputs.

calls: init at 0.0.1 (cherry picked from commit da9b3ea)

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jul 25, 2019

peterhoeg changed the title ~~calls: Initial commit to package the application~~ calls: init at 0.0.1 Jul 25, 2019

peterhoeg requested changes Jul 25, 2019

View reviewed changes

worldofpeace suggested changes Jul 29, 2019

View reviewed changes

infinisil added the 6.topic: Librem 5 label Aug 7, 2019

srhb requested review from worldofpeace and peterhoeg August 23, 2019 07:22

peterhoeg requested changes Aug 23, 2019

View reviewed changes

pkgs/applications/networking/calls/default.nix Outdated Show resolved Hide resolved

pkgs/applications/networking/calls/default.nix Outdated Show resolved Hide resolved

jtojnar reviewed Aug 23, 2019

View reviewed changes

lheckemann force-pushed the calls branch from 6e99182 to 7660329 Compare October 31, 2019 13:03

worldofpeace reviewed Oct 31, 2019

View reviewed changes

lheckemann force-pushed the calls branch from 7660329 to ab99620 Compare November 1, 2019 10:37

worldofpeace reviewed Nov 1, 2019

View reviewed changes

pkgs/applications/networking/calls/default.nix Show resolved Hide resolved

lheckemann force-pushed the calls branch 2 times, most recently from ee3b060 to 694a191 Compare November 10, 2019 18:33

lheckemann and others added 3 commits November 10, 2019 19:40

maintainers: add craigem

0ec60b4

calls: init at 0.0.1

d777bfb

calls: 0.0.1 -> 2019-10-09-unstable

301eb1a

lheckemann force-pushed the calls branch from 694a191 to 301eb1a Compare November 10, 2019 18:40

ofborg bot added the 8.has: package (new) label Nov 10, 2019

ofborg bot requested a review from lheckemann November 10, 2019 18:49

ofborg bot added 11.by: package-maintainer 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 labels Nov 10, 2019

lheckemann merged commit da9b3ea into NixOS:master Nov 10, 2019

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 11, 2019

Merge pull request NixOS#65362 from craigem/calls

4895494

calls: init at 0.0.1 (cherry picked from commit da9b3ea)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

calls: init at 0.0.1 #65362

calls: init at 0.0.1 #65362

craigem commented Jul 25, 2019

craigem commented Jul 25, 2019

worldofpeace commented Jul 25, 2019

craigem commented Jul 25, 2019

craigem commented Jul 25, 2019

worldofpeace commented Jul 27, 2019 •

edited

craigem commented Jul 28, 2019

worldofpeace commented Jul 28, 2019

craigem commented Jul 29, 2019

worldofpeace left a comment •

edited

craigem commented Jul 30, 2019

craigem commented Jul 31, 2019

nixos-discourse commented Aug 7, 2019

worldofpeace commented Aug 23, 2019

jtojnar Aug 23, 2019

worldofpeace Nov 1, 2019

jtojnar commented Aug 23, 2019 •

edited

lheckemann commented Oct 31, 2019

worldofpeace Oct 31, 2019

worldofpeace Oct 31, 2019

worldofpeace commented Oct 31, 2019

worldofpeace commented Oct 31, 2019

lheckemann commented Nov 1, 2019

worldofpeace Nov 1, 2019

worldofpeace Nov 1, 2019

worldofpeace commented Nov 1, 2019

	buildInputs = [ libhandy gnome3.gsound gtk3 gnome3.libpeas gom libxml2 evolution_data_server ];
	buildInputs = [ libhandy gsound gtk3 libpeas gom libxml2 evolution-data-server ];

calls: init at 0.0.1 #65362

calls: init at 0.0.1 #65362

Conversation

craigem commented Jul 25, 2019

Motivation for this change

Things done

craigem commented Jul 25, 2019

worldofpeace commented Jul 25, 2019

craigem commented Jul 25, 2019

craigem commented Jul 25, 2019

worldofpeace commented Jul 27, 2019 • edited

craigem commented Jul 28, 2019

worldofpeace commented Jul 28, 2019

craigem commented Jul 29, 2019

worldofpeace left a comment • edited

Choose a reason for hiding this comment

craigem commented Jul 30, 2019

craigem commented Jul 31, 2019

nixos-discourse commented Aug 7, 2019

worldofpeace commented Aug 23, 2019

jtojnar Aug 23, 2019

Choose a reason for hiding this comment

worldofpeace Nov 1, 2019

Choose a reason for hiding this comment

jtojnar commented Aug 23, 2019 • edited

lheckemann commented Oct 31, 2019

worldofpeace Oct 31, 2019

Choose a reason for hiding this comment

worldofpeace Oct 31, 2019

Choose a reason for hiding this comment

worldofpeace commented Oct 31, 2019

worldofpeace commented Oct 31, 2019

lheckemann commented Nov 1, 2019

worldofpeace Nov 1, 2019

Choose a reason for hiding this comment

worldofpeace Nov 1, 2019

Choose a reason for hiding this comment

worldofpeace commented Nov 1, 2019

worldofpeace commented Jul 27, 2019 •

edited

worldofpeace left a comment •

edited

jtojnar commented Aug 23, 2019 •

edited