gopass: v1.8.5 -> v1.8.6; support wayland #65284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@colemickens I see no reason why we couldn't just |
|
Not that I haven't done it before, but it feels wrong? Anyway, they cut a new release. PR updated, ready to go. |
colemickens
changed the title
|
This has broken installs on Darwin (at least for me) due to inclusion of wl-clipboard which does not build on Darwin. I'm working on a PR to fix the issue. |
|
Ah sorry about that! Let me know if I can help.
…On Tue, Aug 6, 2019, 23:13 Hugo ***@***.***> wrote:
This has broken installs on Darwin (at least for me) due to inclusion of
wl-clipboard which does not build on Darwin. I'm working on a PR to fix the
issue.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#65284?email_source=notifications&email_token=AACP25EHC4V6IZIUJIZBMXLQDHSQLA5CNFSM4IF5TERKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3WPPJA#issuecomment-518846372>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACP25BDTFDE757EPALKQRTQDHSQLANCNFSM4IF5TERA>
.
|
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This will allow Wayland users to use the
--clipfunctionality successfully.This is a DRAFT until
gopasscuts a new release with the necessary commit included. See here: gopasspw/gopass#1118Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)