Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.scrapy: 1.7.1 -> 1.7.2 #65297

Merged
merged 1 commit into from Jul 23, 2019
Merged

pythonPackages.scrapy: 1.7.1 -> 1.7.2 #65297

merged 1 commit into from Jul 23, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 23, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam marsam requested a review from FRidh as a code owner July 23, 2019 10:58
@FRidh
Copy link
Member

FRidh commented Jul 23, 2019

@GrahamcOfBorg build python3Packages.scrapy

@marsam marsam force-pushed the scrapy-python2-configparser-patch branch from cf70ecb to dbfcaee Compare July 23, 2019 14:50
@marsam marsam changed the title pythonPackages.scrapy: update upstream configparser patch pythonPackages.scrapy: 1.7.1 -> 1.7.2 Jul 23, 2019
@aristidb aristidb merged commit 95233e1 into NixOS:master Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marsam @FRidh @aristidb