Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3: add "--enable-optimizations" to configure flags #65298

Closed
wants to merge 1 commit into from
Closed

python3: add "--enable-optimizations" to configure flags #65298

wants to merge 1 commit into from

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 23, 2019

Motivation for this change

Python added support profile guided optimizations(PGO)[1]

[1] https://bugs.python.org/issue26359

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@marsam
python3: add "--enable-optimizations"
570dd22 
Python added support profile guided optimizations(PGO)[1]

[1] https://bugs.python.org/issue26359
@marsam marsam requested a review from FRidh as a code owner July 23, 2019 11:14
@FRidh
Copy link
Member

FRidh commented Jul 23, 2019

Duplicate of #43442.

@FRidh FRidh closed this Jul 23, 2019
@marsam marsam deleted the python3-enable-optimizations branch July 23, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @FRidh