Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mongodb-compass: 1.13.1 -> 1.17.0 #65336

Merged
merged 1 commit into from Aug 3, 2019
Merged

mongodb-compass: 1.13.1 -> 1.17.0 #65336

merged 1 commit into from Aug 3, 2019

Conversation

greydot
Copy link
Contributor

@greydot greydot commented Jul 24, 2019 •
edited

Motivation for this change

Updating MongoDB Compass application.

Please note, while the latest stable version is 1.18.0, this update brings in 1.17.0. I was unable to make 1.18.0 work on NixOS, it ends stuck in an endless loading loop. Compass 1.17.0 seems to work just fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

mmahut
mmahut approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@mmahut mmahut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • reviewed the diff and commit messages
  • made sure ofBorg evals
  • run nix-review without any failures
  • run and tested the binaries

@srhb srhb merged commit 7b0df3c into NixOS:master Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut mmahut approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greydot @mmahut @srhb