-
Notifications
You must be signed in to change notification settings - Fork 445
Comparing changes
Open a pull request
base repository: smoltcp-rs/smoltcp
base: 0f6144331b5a
head repository: smoltcp-rs/smoltcp
compare: efdde337b912
- 13 commits
- 20 files changed
- 2 contributors
Commits on Jun 22, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 4cec6ee - Browse repository at this point
Copy the full SHA 4cec6eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 60b67c4 - Browse repository at this point
Copy the full SHA 60b67c4View commit details -
Travis: turn off notifications.
These are handled via webhooks now.
Configuration menu - View commit details
-
Copy full SHA for 88b54e6 - Browse repository at this point
Copy the full SHA 88b54e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for da1f2a8 - Browse repository at this point
Copy the full SHA da1f2a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30e7bab - Browse repository at this point
Copy the full SHA 30e7babView commit details -
Bump Rust version requirement to 1.27.
This allows us to use: (1.26) - impl Trait - autoderef in pattern matching - fixed slice patterns - inclusive ranges (1.27) - dyn Trait - #[must_use] on functions To prepare for edition change, dyn is added where applicable. Other edition changes would require bumping the requirement even higher, and so they are not applied for now.
Configuration menu - View commit details
-
Copy full SHA for 83dba8e - Browse repository at this point
Copy the full SHA 83dba8eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a4d0a7e - Browse repository at this point
Copy the full SHA a4d0a7eView commit details -
Bump log dependency to version 0.4. NFC.
This doesn't affect downstream code because log 0.3.9 is a facade crate implemented in terms of log 0.4, and so log 0.3 and log 0.4 APIs can be used together.
Configuration menu - View commit details
-
Copy full SHA for bd3912e - Browse repository at this point
Copy the full SHA bd3912eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ed4635 - Browse repository at this point
Copy the full SHA 4ed4635View commit details -
Bump Rust version requirement to 1.28.
Actually, this is not a new requirement at all; because we do not check the minimum version on CI, some dependencies on 1.28 have already sneaked in. In particular, our required version of the crate managed only works on 1.28+. This allows us to use: (1.28) - ops::RangeBounds - num::NonZero Some trait bounds were added to make sure everything builds on 1.28.
Configuration menu - View commit details
-
Copy full SHA for 7faa206 - Browse repository at this point
Copy the full SHA 7faa206View commit details -
Fix potential unsoundness in SocketRef::into_inner()/drop().
This didn't ever actually cause UB because the drop implementation should have compiled to a no-op under all conditions; `finish` is a part of a patchset that never got in. (Even if it didn't, the code should have been dynamically sound, under all but the most strict interpretations of Rust's aliasing requirements.) But it's still a problem, at least because there is a warning for this potential unsoundness that will become an error in the future. So everything else aside, we can't use this pattern going forward. For now, remove the Drop impl, exploiting the fact that `finish` is a no-op. Going forward this will likely require unsafe code, or some fundamental change in the way SocketRef is implemented, but I could not come up with any way to do it. :(
Configuration menu - View commit details
-
Copy full SHA for 1387d40 - Browse repository at this point
Copy the full SHA 1387d40View commit details
Commits on Jul 23, 2019
-
Bump log dependency to version 0.4.4. NFC.
Since 0.4.4, log uses #[macro_export(local_inner_macros)], which is the right thing to do, but it breaks our CI because of a now-unused \#[macro_use(log)].
Configuration menu - View commit details
-
Copy full SHA for 61a42d4 - Browse repository at this point
Copy the full SHA 61a42d4View commit details -
Restore Session::finish call in socket ref
Using move semantics allows an Option to keep track of the initialization state while satisfying the borrow checker. This replaces the functionality that the 'consumed' flag had before. It also retains the smaller object size since the Option of a reference can use the representation of the null pointer, which is an invalid reference, as a niche for the None variant. Closes: #301 Approved by: whitequark
Configuration menu - View commit details
-
Copy full SHA for efdde33 - Browse repository at this point
Copy the full SHA efdde33View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0f6144331b5a...efdde337b912