Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: smoltcp-rs/smoltcp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0f6144331b5a
Choose a base ref
...
head repository: smoltcp-rs/smoltcp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: efdde337b912
Choose a head ref
  • 13 commits
  • 20 files changed
  • 2 contributors

Commits on Jun 22, 2019

  1. Copy the full SHA
    4cec6ee View commit details
  2. Copy the full SHA
    60b67c4 View commit details
  3. Travis: turn off notifications.

    These are handled via webhooks now.
    whitequark committed Jun 22, 2019
    Copy the full SHA
    88b54e6 View commit details
  4. Copy the full SHA
    da1f2a8 View commit details
  5. Copy the full SHA
    30e7bab View commit details
  6. Bump Rust version requirement to 1.27.

    This allows us to use:
    (1.26)
      - impl Trait
      - autoderef in pattern matching
      - fixed slice patterns
      - inclusive ranges
    (1.27)
      - dyn Trait
      - #[must_use] on functions
    
    To prepare for edition change, dyn is added where applicable. Other
    edition changes would require bumping the requirement even higher,
    and so they are not applied for now.
    whitequark committed Jun 22, 2019
    Copy the full SHA
    83dba8e View commit details
  7. Copy the full SHA
    a4d0a7e View commit details
  8. Bump log dependency to version 0.4. NFC.

    This doesn't affect downstream code because log 0.3.9 is a facade
    crate implemented in terms of log 0.4, and so log 0.3 and log 0.4
    APIs can be used together.
    whitequark committed Jun 22, 2019
    Copy the full SHA
    bd3912e View commit details
  9. Copy the full SHA
    4ed4635 View commit details
  10. Bump Rust version requirement to 1.28.

    Actually, this is not a new requirement at all; because we do not
    check the minimum version on CI, some dependencies on 1.28 have
    already sneaked in. In particular, our required version of the crate
    managed only works on 1.28+.
    
    This allows us to use:
    (1.28)
      - ops::RangeBounds
      - num::NonZero
    
    Some trait bounds were added to make sure everything builds on 1.28.
    whitequark committed Jun 22, 2019
    Copy the full SHA
    7faa206 View commit details
  11. Fix potential unsoundness in SocketRef::into_inner()/drop().

    This didn't ever actually cause UB because the drop implementation
    should have compiled to a no-op under all conditions; `finish` is
    a part of a patchset that never got in. (Even if it didn't, the code
    should have been dynamically sound, under all but the most strict
    interpretations of Rust's aliasing requirements.)
    
    But it's still a problem, at least because there is a warning for
    this potential unsoundness that will become an error in the future.
    So everything else aside, we can't use this pattern going forward.
    
    For now, remove the Drop impl, exploiting the fact that `finish`
    is a no-op. Going forward this will likely require unsafe code, or
    some fundamental change in the way SocketRef is implemented, but
    I could not come up with any way to do it. :(
    whitequark committed Jun 22, 2019
    Copy the full SHA
    1387d40 View commit details

Commits on Jul 23, 2019

  1. Bump log dependency to version 0.4.4. NFC.

    Since 0.4.4, log uses #[macro_export(local_inner_macros)], which is
    the right thing to do, but it breaks our CI because of a now-unused
    \#[macro_use(log)].
    whitequark committed Jul 23, 2019
    Copy the full SHA
    61a42d4 View commit details
  2. Restore Session::finish call in socket ref

    Using move semantics allows an Option to keep track of the
    initialization state while satisfying the borrow checker. This replaces
    the functionality that the 'consumed' flag had before. It also retains
    the smaller object size since the Option of a reference can use the
    representation of the null pointer, which is an invalid reference, as a
    niche for the None variant.
    
    Closes: #301
    Approved by: whitequark
    HeroicKatora authored and Homu committed Jul 23, 2019
    Copy the full SHA
    efdde33 View commit details
Loading