Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-ost: update platforms #65381

Merged
merged 1 commit into from Jul 31, 2019
Merged

gh-ost: update platforms #65381

merged 1 commit into from Jul 31, 2019

Conversation

cransom
Copy link
Contributor

@cransom cransom commented Jul 25, 2019

Motivation for this change

It's a typical go app, it shouldn't need to be restricted to just linux. Verified that it compiles and successfully runs on os x.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

worldofpeace
worldofpeace suggested changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

buildGoPackage actually defaults to go.meta.platforms or lib.platforms.all so we actually don't even need to set it here.

@worldofpeace worldofpeace merged commit a1f38f4 into NixOS:master Jul 31, 2019
@worldofpeace
Copy link
Contributor

Thanks @cransom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cransom @worldofpeace