Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] pythonPackages.cq-editor: init at 0.1RC1 #65378

Closed
wants to merge 6 commits into from
Closed

[WIP] pythonPackages.cq-editor: init at 0.1RC1 #65378

wants to merge 6 commits into from
+221 −14

Conversation

costrouc
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@costrouc costrouc requested a review from FRidh as a code owner July 25, 2019 15:09
@costrouc
Copy link
Member Author

Nearly complete and working with the cq-editor but broken for now.

@nixos-discourse
Copy link

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/running-a-qt-application-that-has-been-installed-by-anaconda/3527/7

@samueldr samueldr added the 2.status: work-in-progress This PR isn't done label Jul 27, 2019
marcus7070
marcus7070 reviewed Jul 29, 2019
View reviewed changes
pkgs/development/python-modules/cadquery/default.nix
, fetchFromGitHub
, pyparsing
, opencascade_oce
, pythonocc-core
Copy link
Member

@marcus7070 marcus7070 Jul 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@costrouc, you've probably already noticed this, but CadQuery use their own branch of pythonocc-core and the current one from nixpkgs won't work.

edit: Wait, you said you had CadQuery working? It's possible I've made a mistake somewhere while testing your changes, and the nixpkgs version actually works. I'm a beginner at all this. Let me know if you are interested in where my attempts are going wrong.

@marcus7070
Copy link
Member

marcus7070 commented Aug 2, 2019 •
edited
Loading

@costrouc, I've made some progress in my own fork. I thought I could submit a pull request to costrouc/nixpkgs, but Github won't let me select yours (perhaps there are too many forks of nixpkgs).

I'm not finished yet, just wanted to let you know incase you were currently working on it.

Currently struggling with qtconsole not finding any pyqt version.

[nix-shell:~/tempbuild/nixpkgs]$ cq-editor
Traceback (most recent call last):
  File "/nix/store/in688ijxjgw6ndqkkq92m1y8r6szkdj5-cq-editor-0.1RC1/bin/.cq-editor-wrapped", line 7, in <module>
    from cq_editor.__main__ import main
  File "/nix/store/in688ijxjgw6ndqkkq92m1y8r6szkdj5-cq-editor-0.1RC1/lib/python3.7/site-packages/cq_editor/__main__.py", line 12, in <module>
    from .main_window import MainWindow
  File "/nix/store/in688ijxjgw6ndqkkq92m1y8r6szkdj5-cq-editor-0.1RC1/lib/python3.7/site-packages/cq_editor/main_window.py", line 14, in <module>
    from .widgets.console import ConsoleWidget
  File "/nix/store/in688ijxjgw6ndqkkq92m1y8r6szkdj5-cq-editor-0.1RC1/lib/python3.7/site-packages/cq_editor/widgets/console.py", line 3, in <module>
    from qtconsole.rich_jupyter_widget import RichJupyterWidget
  File "/nix/store/5pygklssig4piyfrdc9sjmdwjclvgqn2-python3.7-qtconsole-4.5.1/lib/python3.7/site-packages/qtconsole/rich_jupyter_widget.py", line 9, in <module>
    from qtconsole.qt import QtCore, QtGui
  File "/nix/store/5pygklssig4piyfrdc9sjmdwjclvgqn2-python3.7-qtconsole-4.5.1/lib/python3.7/site-packages/qtconsole/qt.py", line 23, in <module>
    QtCore, QtGui, QtSvg, QT_API = load_qt(api_opts)
  File "/nix/store/5pygklssig4piyfrdc9sjmdwjclvgqn2-python3.7-qtconsole-4.5.1/lib/python3.7/site-packages/qtconsole/qt_loaders.py", line 387, in load_qt
    api_options))
ImportError: 
    Could not load requested Qt binding. Please ensure that
    PyQt4 >= 4.7, PyQt5, PySide >= 1.0.3 or PySide2 is available,
    and only one is imported per session.

    Currently-imported Qt library:   'pyqt5'
    PyQt4 installed:                 False
    PyQt5 installed:                 False
    PySide >= 1.0.3 installed:       False
    PySide2 installed:               False
    Tried to load:                   ['pyqt5']

@costrouc
Copy link
Member Author

costrouc commented Aug 2, 2019

@marcus7070 since this PR is most important to you do you mind opening a PR for this package? I will close this one. I am happy to give you any help you might need. I will say that the hardest part of this packaging is qt (which I don't have much experience with).

Let me know if this is okay with you and I'll close this PR in favor of yours

@marcus7070
Copy link
Member

@costrouc Sure. I'm going to start an issue for this instead of going straight to a pull request, just in case I hand it off to someone else again.

@marcus7070 marcus7070 mentioned this pull request Aug 3, 2019
Closed
@costrouc
Copy link
Member Author

costrouc commented Aug 3, 2019

Great saw that you opened a PR. Thanks! I will close this one

@costrouc costrouc closed this Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcus7070 marcus7070

@FRidh FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress This PR isn't done 6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@costrouc @nixos-discourse @marcus7070 @samueldr