Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to enable linkage to system-installed libs instead of bundled ones. #451

Closed
Petross404 opened this issue Jul 23, 2019 · 4 comments
Closed

How to enable linkage to system-installed libs instead of bundled ones. #451

Petross404 opened this issue Jul 23, 2019 · 4 comments
Labels
question

Comments

@Petross404
Copy link

Basically the title. I want to use system installed on my gentoo dev-libs/flatbuffers. Running

 build/ $ cmake-gui -DCMAKE_DISABLE_FIND_PACKAGE_FLATBUFFERS=ON ..

doesn't work.

Also I can't find a way to disable it somehow.

message(STATUS "Using in-tree flatbuffers")
set(FLATBUFFERS_BUILD_FLATLIB ON CACHE BOOL "")
set(FLATBUFFERS_BUILD_FLATC ON CACHE BOOL "")
set(FLATBUFFERS_BUILD_FLATHASH OFF CACHE BOOL "")
set(FLATBUFFERS_BUILD_TESTS OFF CACHE BOOL "")
add_subdirectory(extlib/flatbuffers EXCLUDE_FROM_ALL)

What am I missing here? Thank you.
@whitequark
Copy link
Contributor

whitequark commented Jul 23, 2019 •
edited
Loading

This isn't currently supported, mostly because Debian does not ship flatbuffers, and most Linux users of SolveSpace are on Debian derivatives. Is there any particular reason you want it? Flatbuffers are currently only used for writing files, so using a potentially outdated version of them isn't a concern.

@Petross404
Copy link
Author

Petross404 commented Jul 23, 2019 •
edited
Loading

Thank you for your explanation. Yes, the reason I am looking at this is because of gentoo packaging policies. An ebuild for solvespace already exists on the offical portage tree, but there are these policies that want system - installed libraries to be strongly preffered over bundled and avoid auto-magic dependencies.

But anyway, I am not a gentoo dev to take responsibility and as I mentioned an ebuild already exists. So unless the maintainer or a dev approaches you for this, I think you can ignore this issue.

All the best,
Petros

@whitequark
Copy link
Contributor

Flatbuffers is not an automagic dependency as it is a hard requirement (which is also the reason for bundling it). If a Gentoo packager wants me to make it possible to use system flatbuffers they can comment here and I will reopen.

Sorry, something went wrong.

@Petross404
Copy link
Author

Yes, it isn't automagic dep to be honest.

All the best,
Petros

Sorry, something went wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @Petross404