Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urbit: 0.7.4 -> 0.8.0 #65301

Closed
wants to merge 1 commit into from
Closed

urbit: 0.7.4 -> 0.8.0 #65301

wants to merge 1 commit into from

Conversation

jtobin
Copy link
Contributor

@jtobin jtobin commented Jul 23, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtobin
Copy link
Contributor Author

jtobin commented Jul 23, 2019

Does anyone have any advice re: the CI failure here?

In particular, I don't know why the following should be failing like it is (I can't replicate it locally):

cannot import '/nix/store/2jh23bskfidsxs3qcfcahm9kim7d5v7i-source', since path '/nix/store/fg9c5ffzm245w8xpdwryr5k2rgvq5fdr-source.drv' is not valid, at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-0-gleber.ewr1.nix.ci/pkgs/misc/urbit/default.nix:16:11

@flowerornament
Copy link

@jtobin the error seems to reference 'not listing outputs', and I noticed there are no outputs declared at all. The workings of this thing are a lot more complicated than I have time to figure out, but it would appear each of these might be construed as an output?

https://nixos.org/nixpkgs/manual/#chap-multiple-output

@jtobin
Copy link
Contributor Author

jtobin commented Jul 26, 2019

@msutherl I think the CI error message might be a bit misleading; the overall check is an "output path comparison," but it doesn't seem to get far enough to actually check any output paths (which shouldn't be problematic). The problem appears to be in importing the derivation retrieved via fetchFromGitHub -- but this seems to be a CI-only issue, because it works fine locally.

I'll take a look for other derivations in nixpkgs that use this kind of pattern and see if they have any information to add.

@flowerornament
Copy link

This now needs to be bumped to 0.8.1

@jtobin
Copy link
Contributor Author

jtobin commented Sep 8, 2019

(Closing this one pending resolution of urbit/urbit#1369)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants